-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test integration of loop and until options #44927
Test integration of loop and until options #44927
Conversation
9f77f99
to
fc530c1
Compare
This comment has been minimized.
This comment has been minimized.
fc530c1
to
2a28eba
Compare
1920fc3
to
7ebe8f6
Compare
bfa7d1f
to
b4e09df
Compare
64d6099
to
16c7893
Compare
2ca5c19
to
533b592
Compare
is this still something we should merge or should we close at this point? |
@bcoca when I first created it, I recall folks didn't want to merge this because there was no clear decision how this should work. We agreed that it'd be a demo for how it actually works. |
One of the things blocking the merge of #43128 is the current lack of testing for the behaviour of until/retries. While this isn't a comprehensive set of until/retries tests it does improve the current situation and covers many of the loop related scenarios for until. What's the argument against merging this? I don't see any open review items, just a lack of cores adding a final +1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This is needed for split controller/remote
Ref ansible#44741 Ref ansible/proposals#140 * Replace select filter with a more portable thing * Add context This is needed for split controller/remote Co-authored-by: Sam Doran <sdoran@redhat.com>
It looks like
loop
+until
work well together now. @abadger asked me to add tests for this.Ref #44741
Ref ansible/proposals#140
SUMMARY
ISSUE TYPE
COMPONENT NAME
loop, until
ANSIBLE VERSION
ADDITIONAL INFORMATION